Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature_tap_dance.md of Japanese document. #10599

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Update feature_tap_dance.md of Japanese document. #10599

merged 1 commit into from
Oct 12, 2020

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Oct 10, 2020

Description

Update Japanese document.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Oct 10, 2020

@umi-umi @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

@mtei mtei requested a review from a team October 11, 2020 15:20
@mtei
Copy link
Contributor

mtei commented Oct 11, 2020

I think this is ready to merge.

@mtei mtei merged commit a4efb55 into qmk:master Oct 12, 2020
@mtei
Copy link
Contributor

mtei commented Oct 12, 2020

Thanks!

@shelaf shelaf deleted the ja_feature_tap_dance branch October 12, 2020 22:31
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@shelaf
Update Japanese document. (qmk#10599)
bafe172
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@shelaf
Update Japanese document. (qmk#10599)
aac3061
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf
Update Japanese document. (qmk#10599)
57833dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umi-umi umi-umi umi-umi approved these changes

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shelaf @mtei @umi-umi